Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different method to determine successful requests #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SanderVanLeeuwen
Copy link

The current check on 'status' isn't sufficient to detect errors. Not sure if the Front API has changed, but I think it's better to use the availability of the _error object to determine whether a request is successful or not. See http://dev.frontapp.com/#response-body-structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant