Fix bit shifting bug #365
Merged
Fix bit shifting bug #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nadahar could you add a unit test that covers the scenario please? |
Nadahar
force-pushed
the
BitShiftingBug
branch
from
0d1c589
to
fccdd64
Compare
|
@drewnoakes Done. It was a good thing you asked me though, because the 24 bit left shift needed casting to long as well to avoid turning negative if the leftmost bit is 1. From what I can see, |
|
@Nadahar thanks for following up on this. Good stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running FindBugs on latest master per @kwhopper's request , some warnings unrelated to locale/encoding popped up that I just couldn't ignore.
The reason this code will fail as it is, is that Java defines everything as
int(32 bit) by default. As a result, the bits would be "shifted out" and disappear. This should fix it.