Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Module to IR #67

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Add Module to IR #67

merged 1 commit into from
Jun 13, 2024

Conversation

drhagen
Copy link
Owner

@drhagen drhagen commented Jun 13, 2024

Currently, FunctionDefinitions are valid Statements. This is not true in C. Pretending this is true make implementation of LLVM conversion difficult. This adds the concept of a Module to the IR AST, which currently contains only a list of definitions, each of which currently can only be FunctionDefinitions.

imports may be added to Module in the future, but are not currently implemented.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.84%. Comparing base (c3ec481) to head (980fa0a).

Files Patch % Lines
src/tensora/iteration_graph/_generate_ir.py 96.55% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   89.08%   88.84%   -0.24%     
==========================================
  Files          54       54              
  Lines        2986     2995       +9     
  Branches      536      538       +2     
==========================================
+ Hits         2660     2661       +1     
- Misses        249      257       +8     
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drhagen drhagen merged commit 66b87e8 into master Jun 13, 2024
9 checks passed
@drhagen drhagen deleted the function-not-statement branch June 13, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants