Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

In App Purchase and In-App Billing plugins please #361

Closed
EdL opened this issue Oct 7, 2014 · 13 comments
Closed

In App Purchase and In-App Billing plugins please #361

EdL opened this issue Oct 7, 2014 · 13 comments

Comments

@EdL
Copy link

EdL commented Oct 7, 2014

e.g. https://github.com/AlexDisler/ng-storekit

@mrzmyr
Copy link
Contributor

mrzmyr commented Oct 7, 2014

I think there is already a angular plugin for it: https://github.com/AlexDisler/ng-storekit#usage

@EdL
Copy link
Author

EdL commented Oct 7, 2014

Hi @mrzmyr - yes, I can see it is an Angular plugin, that is why I linked to it as an example. I was suggesting that perhaps it could be incorporated into ngCordova though...

@mrzmyr
Copy link
Contributor

mrzmyr commented Oct 7, 2014

If I got the approach right, ngCordova tries to focus more to bring VanillaJS Cordova API's into the AngularJS world and not to integrate other AngularJS services into ngCordova.

@EdL
Copy link
Author

EdL commented Oct 7, 2014

Sorry, I guess I should have been more clear. I'm not suggesting that the actual Angular plugin be incorporated and wrapped, rather I'm suggesting they could implement an ngCordova equivalent in a very similar way to https://github.com/AlexDisler/ng-storekit

I'm aware that I can achieve what I'm after by using that existing plugin. The only advantage would be to have it under the ngCordova module and maintained as part of this repo. If the goal of ngCordova is to implement a comprehensive set of plugins, then I would say In App Purchase is pretty important. Everything else is being added to ngCordova, so why not In App Purchase.

@AlexDisler - what are your thoughts on maybe incorporating your plugin into the ngCordova repo?

@AlexDisler
Copy link

The author of the plugin @j3k0 is working on adding support for Android, and changing the current api to support both Android and iOS. I think it's worth to wait and then perhaps incorporate the new plugin into ngCordova.

j3k0/cordova-plugin-purchase#32

@EdL
Copy link
Author

EdL commented Oct 7, 2014

Thanks for the update @AlexDisler - sounds great. Having it support Android as well would be awesome.

@mlynch
Copy link
Contributor

mlynch commented Oct 7, 2014

We are up to do whatever works. This is MIT so we could always incorporate it and keep the attribution in the source.

What's the consensus? I'm a bit confused which would be preferred.

@EdL
Copy link
Author

EdL commented Oct 7, 2014

If the plugin is currently being altered so it supports Android too, I think it's probably worth waiting and then adding the new one to ngCordova as AlexDisler suggests.

@mrzmyr
Copy link
Contributor

mrzmyr commented Oct 8, 2014

Ouh ok, I think I got you wrong @EdL. I tought you want to reimplement the AngularJS service into ngCordova, but I think what you want is a 'own implementation' of the origin phonegap plugin in ngCrodova.
I think, as @mlynch mentioned, its a idea that makes sense. 👍

@fedme
Copy link

fedme commented Dec 17, 2014

The new multi-platform (Android/iOS) version of the plugin is finally ready and tested thanks to us donors on Indiegogo and other sponsors like Ionic.
Now it would be great to see the plugin integrated into ng-cordova!
https://github.com/j3k0/cordova-plugin-purchase/

@divyenduz
Copy link

This one must be there :)

@jalchr
Copy link

jalchr commented Dec 19, 2014

+100 for having this part of this awesome library :D

@pbernasconi
Copy link
Contributor

Closing this and moving it #262.

@EdL EdL mentioned this issue Mar 30, 2015
15 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants