Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to broken merge. #81

Merged
merged 1 commit into from
Mar 26, 2015
Merged

Minor fix to broken merge. #81

merged 1 commit into from
Mar 26, 2015

Conversation

mathuin
Copy link

@mathuin mathuin commented Mar 25, 2015

At some point when HEAD was rebased or merged with crouton/master, one
conflict went unresolved. I resolved the conflict and was able to use
crouton to successfully generate an arch chroot.

At some point when HEAD was rebased or merged with crouton/master, one
conflict went unresolved.  I resolved the conflict and was able to use
crouton to successfully generate an arch chroot.
@Watney
Copy link

Watney commented Mar 26, 2015

@mathuin Nice work! If you should write down your steps for others to follow (i.e., a Guide), I'd be super interested. My skill level isn't up for the task of installing Arch with an up-to-date crouton. Thanks! (Maybe something for the Arch Wiki?)

@drinkcat
Copy link
Owner

@mathuin : Thanks, sorry for that ,-)

I'm happy to merge it but I'd need you to sign the Individual Contributor License Agreement first, since this will get merged into the main crouton at some point. Thanks!

@mathuin
Copy link
Author

mathuin commented Mar 26, 2015

@drinkcat I have indeed signed the ICLA, how do I prove that to you?

@Watney all I did was use this branch as I would use the master branch of crouton but with "-r arch -t xiwi,cli-extra" as the arguments. Nothing special. :-)

@Watney
Copy link

Watney commented Mar 26, 2015

@mathuin hmm, okay, I'll look closer. Thanks!

drinkcat pushed a commit that referenced this pull request Mar 26, 2015
@drinkcat drinkcat merged commit a720abb into drinkcat:croagh_arch Mar 26, 2015
@drinkcat
Copy link
Owner

Merged. Thanks!

@mathuin
Copy link
Author

mathuin commented Mar 26, 2015

I just learned about the test suite yesterday and ran this branch against the suite. It failed on the xorg target for arch. I am investigating this issue, and will create another branch to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants