git update-index --index-info missing 1 variant

[driusan]

Of the 3 variants of --index-info listed in git-update-index(1) only the one used by the t0000-basic.sh test suite is implemented.

It should be fairly to add support for the other two variants by basing them on the one which is implemented in UpdateIndexFromReader and adding new test cases.

[driusan]

One variant had to be added in #68

[guidopola]

I'm trying to implement this, is there a way to test the git command?

This is the code i have so far.

func UpdateIndexFromReader(c *Client, opts UpdateIndexOptions, r io.Reader) (*Index, error) {
	idx := NewIndex()
	scanner := bufio.NewScanner(r)
	for scanner.Scan() {
		line := strings.TrimSpace(scanner.Text())
		if line == "" {
			continue
		}
		tab := strings.Split(line, "\t")
		if len(tab) != 2 {
			return nil, fmt.Errorf("Invalid line in index-info: %v", line)
		}
		path := tab[1]
		spaces := strings.Split(tab[0], " ")
		switch len(spaces) {
		case 2:
			// mode SP sha1 TAB path
			mode, err := ModeFromString(spaces[0])
			if err != nil {
				return nil, err
			}
			sha1, err := Sha1FromString(spaces[1])
			if err != nil {
				return nil, err
			}
			if err := idx.AddStage(c, IndexPath(path), mode, sha1, Stage0, 0, 0, UpdateIndexOptions{Add: true}); err != nil {
				return nil, err
			}
		case 3:
.....

[driusan]

I'm not sure what you mean by "test". Do you want to write an automated test that runs with go test or do you just want to see if your output is right after running the command in any given git repo?

To see the status of the index in the current git dirgit ls-files --stage should be sufficient to show the details that are managed by git update-index --index-info.. it prints "mode sha1 stage\tpath" for each file in the index. To do automated testing, idx.Objects is a slice of git.IndexEntry pointers which get serialized to the index when dgit does something that requires saving the index.

[guidopola]

Sorry if i didn't explain me very well. My english is very bad.
What i meant was to check the output after running the command because i found the official-git/run-tests.sh script but i have no idea how to use it.
(It would be nice to have a small guide in the readme file on how to use it)

[driusan]

There's the wiki page that @sirnewton01 wrote at https://github.com/driusan/dgit/wiki/Verify-dgit-using-official-git-tests, but the easiest way to check that there's no regressions is to send a PR. All the known passing tests are run by Travis automatically and a green checkmark means they passed.