Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the long filename test from the basic suite #61

Merged
merged 6 commits into from
Jul 21, 2018

Conversation

sirnewton01
Copy link
Collaborator

This one test case from the basic test suite is quite an edge case considering that it would be impractical to create an index entry with such a long name from either Mac or Linux due to local filesystem restrictions. It would be good to get the rest of the basic suite running, but this one can wait until later.

In this PR, there is plumbing in the run-official-tests script to apply patches to the test suites before running them and a patch file that skips this particular test.

@driusan
Copy link
Owner

driusan commented Jul 20, 2018

I'm going to sit on this PR until it's the only thing preventing us from making the official test suite fail the build, just in case there's a solution before then.

But can we move all the test stuff to a subdirectory instead of the root?

@sirnewton01
Copy link
Collaborator Author

Okay, sounds good. I have pushed a new commit that restructures all official git test related files into its own subdirectory. Also, travis no longer passes the "-i" parameter to make so any test failures will fail the build. Note that this will likely fail right now until we get the other tests passing.

@sirnewton01
Copy link
Collaborator Author

I've pulled out the patch approach and went with an environment variable instead and added that to the travis script. I'm going to check now that it works there.

@sirnewton01
Copy link
Collaborator Author

I've rebased the latest changes. Hopefully this build will be green now that everything is working except the long filenames. Now, we will find regressions discovered by the official git test suite right away because the CI builds will fail. Two person-weeks worth of effort but I think we've made a lot of good progress on this project.

@driusan driusan merged commit f011464 into driusan:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants