#145 import image series #233

vessemer · 2017-11-19T01:43:36Z

Import image series implementation.

Reference to official issue

This addresses #145

Screenshots:

CLA

I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well

louisgv · 2017-11-19T02:15:41Z

interface/frontend/src/components/open-image/ImageSeries.vue

@@ -80,6 +87,7 @@
  import { EventBus } from '../../main.js'
  import TreeView from './TreeView'
  import OpenDicom from './OpenDICOM'
+  const dirname = require('path-dirname')


Hmm, seems like this module cannot be used with import? I thought import dirname from 'path-dirname' would work.

Well, yes, it works like you thought. I was confused by this this obstacle for the cornerstone and cornerstone-tools. Thanks for pointing that out!

Serhiy-Shekhovtsov · 2017-11-19T12:28:13Z

@vessemer, I think it's a good idea to let others know when you are working on an issue (like I did here) if we are choosing collaboration over competition. This way team members will not waste their time working on same tasks.

Serhiy-Shekhovtsov · 2017-11-19T12:52:04Z

Image loading is also a part of this PR that also shows currently running case, allows user to import and start new case after preview image, as it was described in documentation.

vessemer · 2017-11-20T05:58:24Z

lamby · 2017-11-21T00:20:30Z

FYI I've started a discussion here #236 (comment) regarding the potential feature conflict..

vessemer · 2017-11-23T02:03:37Z

Serhiy-Shekhovtsov · 2017-11-24T15:46:09Z

interface/backend/api/views.py

+
+
+@api_view(['POST'])
+def case_available(request):


There is no need to create a new method. cases/ will do just fine.

Serhiy-Shekhovtsov · 2017-11-24T15:49:17Z

interface/frontend/src/components/open-image/ImageSeries.vue

+                      class="btn btn-primary float-left case-btn">
+                Create new case
+              </button>
+              <a href="#/report-and-export" class="btn btn-primary float-left case-btn">Start case</a>


As far as I understood from this comment we should have multiple cases running same time. So there is no need to have Start case button. At least until there is no any role for it :)

Serhiy-Shekhovtsov · 2017-11-24T15:51:57Z

interface/frontend/src/components/open-image/ImageSeries.vue

+                      class="btn btn-primary float-left case-btn">
+                Create new case
+              </button>
+              <a href="#/report-and-export" class="btn btn-primary float-left case-btn">Start case</a>
            </template>
            <template v-else>
              <p class="card-text">No images imported.</p>
            </template>
            <button class="btn btn-warning float-right"


Please, remove this button(Show\Hide import) and make the tree view always visible, there is nothing else to show on this page. The only role of this page is to select a file and start the case, so there is no reason to require user to do extra clicks.

Serhiy-Shekhovtsov · 2017-11-24T15:54:46Z

interface/frontend/src/components/open-image/ImageSeries.vue

@@ -123,10 +136,28 @@
            // TODO: handle error
          })
      },
+      async fetchExistedCases (series) {


fetchExistedCases -> fetchExistingCases

Serhiy-Shekhovtsov · 2017-11-24T15:56:21Z

interface/frontend/src/components/open-image/ImageSeries.vue

@@ -141,6 +172,9 @@
 </script>

 <style lang="scss" scoped>
+  .case-btn {
+    margin-left: 1% 


Bootstrap has classes like ml-1, ml-2 etc. for margins. Check this.

Serhiy-Shekhovtsov · 2017-11-24T15:57:01Z

interface/frontend/src/components/open-image/ImageSeries.vue

@@ -141,6 +172,9 @@
 </script>

 <style lang="scss" scoped>
+  .case-btn {
+    margin-left: 1% 
+  }
  .left {
    float: left;


You can use Bootstrap class .pull-left for this.

Serhiy-Shekhovtsov · 2017-11-24T16:02:32Z

One more thing, since you have fixed the DICOM viewer - user can scroll through slices now. So, clicking on last folder should actually show the image. No need to show list of files. You can use my code here.

lamby · 2017-11-24T22:24:10Z

Thanks for reviewing @Serhiy-Shekhovtsov :)

lamby · 2017-11-27T00:31:27Z

Hey @vessemer, I assume you got all these comments, etc.? :)

lamby · 2017-11-27T23:23:35Z

No rush of course but the build seems to be failing and, alas, we need to resolve these conflicts :)

lamby · 2017-11-28T22:28:56Z

Gentle ping on this? :)

Serhiy-Shekhovtsov · 2017-11-29T21:05:18Z

@lamby, @reubano, I can reopen and update my PR if it will help us to proceed on this.

reubano · 2017-12-01T01:01:00Z

@Serhiy-Shekhovtsov no worries. tests are now passing and conflicts have been fixed.

reubano · 2017-12-01T05:15:30Z

Well, for whatever reason I'm not able to duplicate your screencasts. Here's what I get.

lamby · 2017-12-01T09:10:21Z

@Serhiy-Shekhovtsov Thanks so much. However, I still see two remaining conflcts? :)

Serhiy-Shekhovtsov · 2017-12-01T09:36:25Z

Great job @vessemer! Few small comments from my side:

there are two buttons on the page: Create case and Start case and one of them does nothing but confuses the user :)
also I think we should not show the list of files under last folder. Because once we switch to real data - we'll see hundreds of files there. It will make it complicated for user to browse the tree and this list doesn't do any help, cause the DICOM viewer should already support scrolling through slices. Again, you can copy\merge this code.

reubano · 2017-12-01T18:57:27Z

Turns out I forgot the --hard option in my git reset command. I'm getting the changed code now. Is there a data import step I need to run first?

I'm getting this:

vue_1            |  DONE  Compiled successfully in 25960ms18:58:35
vue_1            | 
vue_1            | > Listening at http://0.0.0.0:8080
vue_1            | 
vue_1            | [HPM] Error occurred while trying to proxy request /api/images/ from 52.207.235.82:8080 to http://interface:8000 (ENOTFOUND) (https://nodejs.org/api/errors.html#errors_common_system_errors)

lamby · 2017-12-05T07:20:20Z

@vessemer Ping on this? :)

reubano · 2017-12-05T15:23:28Z

Anyone else seeing an [HPM] Error? I'm still getting it. Even on master.

reubano · 2017-12-05T16:32:12Z

Re-ran everything and it's looking good now!

reubano · 2017-12-05T17:21:36Z

@Serhiy-Shekhovtsov great suggestions above. I've just fixed the conflicts so this PR should be merged soon. Mind submitting issues and accompanying PRs of your ideas?

reubano · 2017-12-05T17:23:48Z

Great job @vessemer! Once the tests complete (and hopefully pass!) do you mind rebasing everything to 1 commit? Thanks!

Serhiy-Shekhovtsov · 2017-12-05T18:23:50Z

We should not show the list of files under last folder. Because once we switch to real data - we'll see hundreds of files there. It will make it complicated for user to browse the tree and this list doesn't do any help, cause the DICOM viewer should already support scrolling through slices.

This is still not fixed, right?

reubano · 2017-12-05T18:28:12Z

@Serhiy-Shekhovtsov correct.

reubano · 2017-12-05T20:06:02Z

There's a candidate_dismiss is not defined error in interface/backend/api/urls.py.

Case manager Handy case selection some fixes

isms · 2017-12-05T20:48:21Z

FYI, @pjbull and I are in the midst of a cleanup and refactor right now that will take these changes into account - we can mark this is semi-accepted (thanks @vessemer and @Serhiy-Shekhovtsov for all the footwork). We'll credit appropriately.

[cc @reubano]

lamby · 2017-12-09T08:38:14Z

@isms Don't forget to re-ping here once done so we can resolve the conflicts :)

isms · 2017-12-11T17:34:32Z

@lamby All set from my perspective - we can close this and acknowledge contributors with full points. (This PR was really helpful in framing how we wanted things to work here, it just ended up being too far from the major refactored version to merge as-is. It otherwise would have been merged 👍)

lamby · 2017-12-12T08:53:01Z

@isms Done! Many thanks all o/

louisgv reviewed Nov 19, 2017

View reviewed changes

vessemer force-pushed the 145_image_series_register branch from d49288b to 06122d2 Compare November 19, 2017 07:00

Serhiy-Shekhovtsov mentioned this pull request Nov 20, 2017

'Import' UI element should be able to create backend ImageSeries model instance #145

Closed

5 tasks

lamby mentioned this pull request Nov 21, 2017

Implemented Imagery selection screen #236

Closed

1 task

vessemer force-pushed the 145_image_series_register branch from baefcbc to 4c1420f Compare November 23, 2017 02:01

Serhiy-Shekhovtsov suggested changes Nov 24, 2017

View reviewed changes

Serhiy-Shekhovtsov mentioned this pull request Nov 26, 2017

Detect and select: attaching nodule centroid marker to current slice #250

Merged

1 task

vessemer force-pushed the 145_image_series_register branch 2 times, most recently from 74ebeb6 to 7530822 Compare November 29, 2017 18:18

vessemer force-pushed the 145_image_series_register branch from 7530822 to 79ecca7 Compare November 29, 2017 22:08

vessemer force-pushed the 145_image_series_register branch from 3611f1c to 49ce1ac Compare December 5, 2017 19:20

import image series

cc82522

Case manager Handy case selection some fixes

vessemer force-pushed the 145_image_series_register branch from 49ce1ac to cc82522 Compare December 5, 2017 20:26

lamby closed this Dec 12, 2017



		@api_view(['POST'])
		def case_available(request):

#145 import image series #233

#145 import image series #233

Conversation

vessemer commented Nov 19, 2017 • edited

Reference to official issue

Screenshots:

CLA

louisgv Nov 19, 2017 • edited

Choose a reason for hiding this comment

vessemer Nov 19, 2017 • edited

Choose a reason for hiding this comment

Serhiy-Shekhovtsov commented Nov 19, 2017

Serhiy-Shekhovtsov commented Nov 19, 2017

vessemer commented Nov 20, 2017

lamby commented Nov 21, 2017

vessemer commented Nov 23, 2017

Serhiy-Shekhovtsov Nov 24, 2017

Choose a reason for hiding this comment

Serhiy-Shekhovtsov Nov 24, 2017

Choose a reason for hiding this comment

Serhiy-Shekhovtsov Nov 24, 2017 • edited

Choose a reason for hiding this comment

Serhiy-Shekhovtsov Nov 24, 2017

Choose a reason for hiding this comment

Serhiy-Shekhovtsov Nov 24, 2017 • edited

Choose a reason for hiding this comment

Serhiy-Shekhovtsov Nov 24, 2017

Choose a reason for hiding this comment

Serhiy-Shekhovtsov commented Nov 24, 2017 • edited

lamby commented Nov 24, 2017

lamby commented Nov 27, 2017

lamby commented Nov 27, 2017

lamby commented Nov 28, 2017

Serhiy-Shekhovtsov commented Nov 29, 2017

reubano commented Dec 1, 2017

reubano commented Dec 1, 2017

lamby commented Dec 1, 2017

Serhiy-Shekhovtsov commented Dec 1, 2017 • edited

reubano commented Dec 1, 2017 • edited

lamby commented Dec 5, 2017

reubano commented Dec 5, 2017

reubano commented Dec 5, 2017 • edited

reubano commented Dec 5, 2017

reubano commented Dec 5, 2017

Serhiy-Shekhovtsov commented Dec 5, 2017

reubano commented Dec 5, 2017

reubano commented Dec 5, 2017

isms commented Dec 5, 2017

lamby commented Dec 9, 2017

isms commented Dec 11, 2017

lamby commented Dec 12, 2017

vessemer commented Nov 19, 2017 •

edited

louisgv Nov 19, 2017 •

edited

vessemer Nov 19, 2017 •

edited

Serhiy-Shekhovtsov Nov 24, 2017 •

edited

Serhiy-Shekhovtsov Nov 24, 2017 •

edited

Serhiy-Shekhovtsov commented Nov 24, 2017 •

edited

Serhiy-Shekhovtsov commented Dec 1, 2017 •

edited

reubano commented Dec 1, 2017 •

edited

reubano commented Dec 5, 2017 •

edited