Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Conversion spelling #332

Closed
wants to merge 40 commits into from

Conversation

Cash4Programming
Copy link
Contributor

Updated the spelling of deca/deka based on the detected browser language.

… and converted all fraction to decimals into a division.
…last column was Yes/No not a number. Other bug fixes in the ismixed sections
# Conflicts:
#	assessment/libs/simplex.php
@Cash4Programming
Copy link
Contributor Author

I hope I did this correctly this time. If not message me in WAMAP so I can fix this. Thanks.

Mike

@drlippman
Copy link
Owner

Why? The gettext _ function already allows localization, and handles it in general for any language. Why restrict it to only handle a few languages? (Though I suppose most languages probably don't spell the units differently)

I'm also concerned with displaying the British spelling for the units here, when the units handling code for number questions only handles the US spelling.

…plexcreatelatexinequalities to return the latex version of the objective and constraints.
@Cash4Programming
Copy link
Contributor Author

Updated the function to use the gettext() _ function from a function at the top of the file (conversion).

Added simplexcreatelatexinequalities in the simplex and updated the simplex html

@drlippman
Copy link
Owner

Your original code had already used _ for localization, so I'm still confused what problem this change is trying to solve.

@drlippman
Copy link
Owner

Also, I just realized that gettext is based on server-declared language, so can't adapt to the client's language preference like you were trying to do here. If your goal is for the same server to deliver both spellings, it might be necessary to go back to your original model, but with gettext used on the fallback case to account for other languages.

@Cash4Programming
Copy link
Contributor Author

Cash4Programming commented May 7, 2022 via email

@Cash4Programming
Copy link
Contributor Author

Cash4Programming commented May 7, 2022 via email

@Cash4Programming
Copy link
Contributor Author

I will close this and request and use the gettext() as the fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants