Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add blinky for stm32l4xx #42

Closed
wants to merge 1 commit into from
Closed

add blinky for stm32l4xx #42

wants to merge 1 commit into from

Conversation

ctron
Copy link
Member

@ctron ctron commented Jun 21, 2021

No description provided.

@ctron ctron mentioned this pull request Jun 25, 2021
Closed
@ctron ctron marked this pull request as ready for review June 25, 2021 14:30
@ctron ctron requested review from bobmcwhirter and lulf June 25, 2021 14:31
@ctron ctron added the enhancement New feature or request label Jun 25, 2021
lulf
lulf approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but I wonder if the example can be simplified (i.e. remove app.rs) if you use the Led actor instead of adding the App actor.

@dejanb
Copy link
Member

dejanb commented Aug 20, 2021

Lgtm, but I wonder if the example can be simplified (i.e. remove app.rs) if you use the Led actor instead of adding the App actor.

I created a simplified example as a base for the wifi work in #63. I can update this PR if @ctron is willing to test it out 🙂

@lulf
Copy link
Member

lulf commented Nov 23, 2021

Should we close this? It's very outdated and we have the wifi board example for L4 now. Wdyt @ctron ?

@ctron ctron closed this Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lulf lulf lulf approved these changes

@bobmcwhirter bobmcwhirter Awaiting requested review from bobmcwhirter

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctron @dejanb @lulf