This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
feat: Add discolorate animation and refactored patch function
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: Refactored apiChangeProperty a little
❌ Deploy Preview for newcar-copy failed.
|
❌ Deploy Preview for newcar-playground failed. Why did it fail? →
|
❌ Deploy Preview for newcar-docs failed. Why did it fail? →
|
❌ Deploy Preview for newcar-apis failed. Why did it fail? →
|
jiwangyihao
reviewed
Jun 1, 2024
Comment on lines
+13
to
+18
| const changedProps = [ | ||
| 'style.fillColor.red', | ||
| 'style.fillColor.green', | ||
| 'style.fillColor.blue', | ||
| 'style.fillColor.alpha', | ||
| ] |
There was a problem hiding this comment.
需要使用颜色动画的不只是 fillColor，还可能有 borderColor 以及组件自定义的其他颜色选项
There was a problem hiding this comment.
哦，就是跟颜色相关的东西吧
我想可以给他们重新写几个文件，而不应该在这个函数上再做抽象来增加用户的理解难度
There was a problem hiding this comment.
重复写动画实际上有点不合理，因为自定义组件特有的颜色选项是开放的 API（这意味着它可能会是各种莫名其妙的名字），内置的动画泛用性还是应该更强一点（我觉得）
There was a problem hiding this comment.
OK, 我会考虑你的建议，现在我把它修改了，若在实际使用中出现问题再论。
Cheers! :)
There was a problem hiding this comment.
你把原来的demo全部复制粘贴上去，然后你就会发现几个问题：
- 帧率大大降低
- 原来的组件位置都有偏差
我想这两个漏洞都与你修改了patch有关
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING!
Must be tested carefully!