Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/logs state management #350

Merged
merged 5 commits into from
Mar 24, 2021
Merged

Fix/logs state management #350

merged 5 commits into from
Mar 24, 2021

Conversation

bolotskydev
Copy link
Contributor

  • prevented state sharing between build pages by addin key prop to route
  • improved fetch logs condition
  • changed build pending state: non logs => loading
  • adjusted logs reducer actions
  • improved useLogs to cause less state interventions
  • status now have title att to help user distinguish statuses
  • if there is no data.started, elapsed component at build header is hidden
  • removed console from summary

Kirill Bolotsky added 4 commits March 22, 2021 15:31
- prevented state sharing between build pages by addin key prop to route
- improved fetch logs condition
- changed build pending state: non logs => loading
- adjusted logs reducer actions
- improved useLogs to cause less state interventions
- status now have title att to help user distinguish statuses
- if there is no data.started, elapsed component at build header is hidden
- removed console from summary
Side:
- extended build based next state computation with one more case
@bradrydzewski bradrydzewski merged commit 4590040 into drone2 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants