Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip trailing slash from url to fix build link bug #398

Merged
merged 2 commits into from
Jan 5, 2022
Merged

strip trailing slash from url to fix build link bug #398

merged 2 commits into from
Jan 5, 2022

Conversation

d1wilko
Copy link
Contributor

@d1wilko d1wilko commented Jan 5, 2022

also general lint fixes

@eoinmcafee00 eoinmcafee00 self-requested a review January 5, 2022 15:34
@bradrydzewski
Copy link
Member

could this impact multiple pages? wondering if this could be solved at the router level instead to trim all trailing slashes?
https://jasonwatmore.com/post/2020/03/23/react-router-remove-trailing-slash-from-urls

@d1wilko
Copy link
Contributor Author

d1wilko commented Jan 5, 2022

@bradrydzewski yes it can :) I've updated the PR

@d1wilko d1wilko merged commit 28f7604 into main Jan 5, 2022
@d1wilko d1wilko deleted the bug/dron-183 branch January 5, 2022 16:55
@d1wilko d1wilko added the bug label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eoinmcafee00 eoinmcafee00 eoinmcafee00 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@d1wilko @bradrydzewski @eoinmcafee00