Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [CDS-67745]: fix find user email api for bitbucket in go-scm #255

Merged
merged 2 commits into from
Apr 28, 2023
Merged

fix: [CDS-67745]: fix find user email api for bitbucket in go-scm #255

merged 2 commits into from
Apr 28, 2023

Conversation

shalini-agr
Copy link
Contributor

@shalini-agr shalini-agr commented Apr 28, 2023

Changes: Added support for findEmail API in bitbucket.
Testing: Tested locally by using this library in a test snippet that the correct email id was returned.

@CLAassistant
Copy link

CLAassistant commented Apr 28, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@tphoney tphoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change, for cleanliness can you squash your commits and give the commit a descriptive message. "fix" is not helpful

@tphoney tphoney merged commit 194f53f into drone:master Apr 28, 2023
@tphoney tphoney added the bug label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants