Feature/codegen refactor

[mknejp]

More details about this can be found here: #70

This includes #40 and #39.

[skabbes]

Any particular reason for the lib and compiler changes?

[mknejp]

I'm actually not sure anymore. I think I was trying it out on both compilers for warnings and probably forgot to discard the change. Maybe it was because of the need for C++14 in the support lib. I don't see a reason why it shouldn't work with GCC

[izacus]

Last I tested the 4.8 GCC toolchain was missing std::experimental:optional which prompted the switch in our code.

[j4cbo]

So I'm slowly cherry-picking the individual changes here to go through the necessary updates to our code that uses it. It looks like the JNI codegen change has issues compiling the test suite:

 [exec] In file included from ../generated-src/jni/NativeNestedCollection.cpp:5:
 [exec] ../../support-lib/jni/Marshal.hpp:245:32: error: no member named 'Boxed' in 'djinni::Set<djinni::String>'
 [exec]                 using EJniType = typename T::Boxed::JniType;
 [exec]                                           ~~~^
 [exec] ../generated-src/jni/NativeNestedCollection.cpp:17:70: note: in instantiation of template class 'djinni::List<djinni::Set<djinni::String> >' requested here
 [exec]                                                            ::djinni::List<::djinni::Set<::djinni::String>>::fromCpp(jniEnv, c.set_list).get())};
 [exec]                                                                      ^
 [exec] In file included from ../generated-src/jni/NativeMapListRecord.cpp:5:
 [exec] ../../support-lib/jni/Marshal.hpp:245:32: error: no member named 'Boxed' in 'djinni::Map<djinni::String, djinni::I64>'
 [exec]                 using EJniType = typename T::Boxed::JniType;
 [exec]                                           ~~~^
 [exec] ../generated-src/jni/NativeMapListRecord.cpp:17:70: note: in instantiation of template class 'djinni::List<djinni::Map<djinni::String, djinni::I64> >' requested here
 [exec]                                                            ::djinni::List<::djinni::Map<::djinni::String, ::djinni::I64>>::fromCpp(jniEnv, c.map_list).get())};
 [exec]                                                                      ^

I get the same errors on the latest feature/codegen-refactor in your fork.

Can you rebase the remaining changes on top of current master and fix the compilation issues? Thanks!

[mknejp]

Hmm it seems my test setup was borked and the Java tests weren't running properly, weird.
Not every single commit may compile and run tests on its own though, I have to admit that I often do several commits in sequence and then regenerate/run tests before pushing the commits to keep the diffs focused. Not very helpful in this situation.

Anyway, since trying to rebase the existing branch is now giving a bazillion conflicts I'll have to make a new one and try to split it over separate pull requests where I can. Sorry for the inconvenience.