Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI test environment #391

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Fix CI test environment #391

merged 1 commit into from
Oct 15, 2021

Conversation

Brent1LT
Copy link
Contributor

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does tox pass?
  • Do the tests pass?

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #391 (452072e) into main (45ccf50) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   64.22%   64.22%           
=======================================
  Files          30       30           
  Lines       51156    51156           
  Branches     3747     3747           
=======================================
  Hits        32854    32854           
  Misses      18145    18145           
  Partials      157      157           
Flag Coverage Δ
integration 64.13% <ø> (ø)
unit 63.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45ccf50...452072e. Read the comment docs.

@rogebrd
Copy link
Contributor

rogebrd commented Oct 14, 2021

It looks like the integration tests didn't get migrated as well, can we update that? We will also need to update the config for the required checks

@Brent1LT Brent1LT force-pushed the fix_ci_tests branch 2 times, most recently from 9af6a5c to 23491f5 Compare October 15, 2021 17:49
@Brent1LT Brent1LT merged commit 2dc18a1 into main Oct 15, 2021
@Brent1LT Brent1LT deleted the fix_ci_tests branch October 15, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants