Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very near other fields match #13

Closed
ghost opened this issue Aug 16, 2012 · 2 comments
Closed

Very near other fields match #13

ghost opened this issue Aug 16, 2012 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 16, 2012

I'm currently implementing this on a site and several users found that they can enter their password without the @ sign. I pass the email in the input fields argument. I'm not sure if this needs a stronger check, for instance a user might use a combination of their name and company for the password. So perhaps any instance of another field found anywhere in the password should reduce the strength, and a match of the password without the @ sign fail?

@lowe
Copy link
Collaborator

lowe commented Aug 17, 2012

Hi PXLRic,

the second argument to zxcvbn(), user_inputs, can be any list of tokens you like. So you could add all of these yourself to get the behavior you're looking for:

myemail@example.com
myemailexample.com
myemail
example.com

Cheers,
Dan

@ghost
Copy link
Author

ghost commented Aug 17, 2012

Good point!

On 17/08/2012 01:52, Dan Wheeler wrote:

Hi PXLRic,

the second argument to zxcvbn(), user_inputs, can be any list of
tokens you like. So you could add all of these yourself to get the
behavior you're looking for:

myemail@example.com mailto:myemail@example.com
myemailexample.com
myemail
example.com

Cheers,
Dan


Reply to this email directly or view it on GitHub
#13 (comment).

@lowe lowe closed this as completed Jan 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant