Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for a string matching exactly user input #15

Closed
lstrojny opened this issue Dec 4, 2012 · 2 comments
Closed

False positive for a string matching exactly user input #15

lstrojny opened this issue Dec 4, 2012 · 2 comments

Comments

@lstrojny
Copy link

lstrojny commented Dec 4, 2012

We are using firstname, lastname and email as parts of the blacklist. The following call returns a very high score, nevertheless the email address is part of the blacklist:

var mail = 'Immer.noch.nicht.Invited@mail.com',
    blacklist = ['Immer.noch.nicht.Invited@mail.com'];

console.log(zxcvbn(mail, blacklist));
{
  "password":"Immer.noch.nicht.Invited@mail.com",
  "entropy":111.544,
  "match_sequence":[
    {
      "pattern":"dictionary",
      "i":0,
      "j":0,
      "token":"I",
      "matched_word":"i",
      "rank":2,
      "dictionary_name":"english",
      "base_entropy":1,
      "uppercase_entropy":1,
      "l33t_entropy":0,
      "entropy":2
    },
    {
      "pattern":"bruteforce",
      "i":1,
      "j":1,
      "token":"m",
      "entropy":6.409390936137703,
      "cardinality":85
    },
    {
      "pattern":"dictionary",
      "i":2,
      "j":3,
      "token":"me",
      "matched_word":"me",
      "rank":10,
      "dictionary_name":"english",
      "base_entropy":3.3219280948873626,
      "uppercase_entropy":0,
      "l33t_entropy":0,
      "entropy":3.3219280948873626
    },
    {
      "pattern":"bruteforce",
      "i":4,
      "j":5,
      "token":"r.",
      "entropy":12.818781872275405,
      "cardinality":85
    },
    {
      "pattern":"dictionary",
      "i":6,
      "j":7,
      "token":"no",
      "matched_word":"no",
      "rank":18,
      "dictionary_name":"english",
      "base_entropy":4.169925001442312,
      "uppercase_entropy":0,
      "l33t_entropy":0,
      "entropy":4.169925001442312
    },
    {
      "pattern":"bruteforce",
      "i":8,
      "j":10,
      "token":"ch.",
      "entropy":19.228172808413106,
      "cardinality":85
    },
    {
      "pattern":"dictionary",
      "i":11,
      "j":15,
      "token":"nicht",
      "matched_word":"nicht",
      "rank":24155,
      "dictionary_name":"english",
      "base_entropy":14.56003423231944,
      "uppercase_entropy":0,
      "l33t_entropy":0,
      "entropy":14.56003423231944
    },
    {
      "pattern":"bruteforce",
      "i":16,
      "j":16,
      "token":".",
      "entropy":6.409390936137703,
      "cardinality":85
    },
    {
      "pattern":"dictionary",
      "i":17,
      "j":23,
      "token":"Invited",
      "matched_word":"invited",
      "rank":1175,
      "dictionary_name":"english",
      "base_entropy":10.198445041452363,
      "uppercase_entropy":1,
      "l33t_entropy":0,
      "entropy":11.198445041452363
    },
    {
      "pattern":"dictionary",
      "i":24,
      "j":24,
      "token":"@",
      "matched_word":"a",
      "rank":5,
      "dictionary_name":"english",
      "l33t":true,
      "sub":{
        "@":"a"
      },
      "sub_display":"@ -> a",
      "base_entropy":2.321928094887362,
      "uppercase_entropy":0,
      "l33t_entropy":1,
      "entropy":3.321928094887362
    },
    {
      "pattern":"dictionary",
      "i":25,
      "j":28,
      "token":"mail",
      "matched_word":"mail",
      "rank":1135,
      "dictionary_name":"english",
      "base_entropy":10.148476582178278,
      "uppercase_entropy":0,
      "l33t_entropy":0,
      "entropy":10.148476582178278
    },
    {
      "pattern":"bruteforce",
      "i":29,
      "j":29,
      "token":".",
      "entropy":6.409390936137703,
      "cardinality":85
    },
    {
      "pattern":"dictionary",
      "i":30,
      "j":32,
      "token":"com",
      "matched_word":"com",
      "rank":2994,
      "dictionary_name":"english",
      "base_entropy":11.547858506058418,
      "uppercase_entropy":0,
      "l33t_entropy":0,
      "entropy":11.547858506058418
    }
  ],
  "crack_time":1.8922410863462927e+29,
  "crack_time_display":"centuries",
  "score":4,
  "calc_time":10
}
@lstrojny
Copy link
Author

Ping

lowe pushed a commit that referenced this issue Jan 23, 2013
@lowe
Copy link
Collaborator

lowe commented Jan 23, 2013

thanks and sorry for the delay. this was a capitalization bug, fixed now:
a9fa79e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants