Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zxcvbn-async.js contains hard coded incorrect path #67

Closed
pete4abw opened this issue Mar 17, 2015 · 5 comments · Fixed by #72
Closed

zxcvbn-async.js contains hard coded incorrect path #67

pete4abw opened this issue Mar 17, 2015 · 5 comments · Fixed by #72

Comments

@pete4abw
Copy link

src="//dl.dropbox.com/u/209/zxcvbn/zxcvbn.js"

should probably be:

src="zxcvbn.js"

@tomsommer
Copy link
Contributor

+1 Please fix this

tomsommer added a commit to tomsommer/zxcvbn that referenced this issue Apr 29, 2015
@lowe
Copy link
Collaborator

lowe commented Apr 29, 2015

I did this on purpose to make it as easy as possible to set up zxcvbn, as well as allow people to download the bulk from Dropbox's CDN.

That said, I've seen enough confusion that I don't mind changing.

@lowe lowe closed this as completed Apr 29, 2015
@tomsommer
Copy link
Contributor

Thanks. Could you recompile the coffee too? Or what is the procedure for the .js files?

@tomsommer
Copy link
Contributor

There is an issue with the change.

If zxcvbn.js is stored in /bower_components/zxcvbn/zxcvbn.js the call from /bower_components/zxcvbn/zxcvbn-async.js with src = 'zxcvbn.js' will call '/zxcvbn.js', resulting in a 404

I'm not entirely sure how to fix this without requiring people to edit the -async.js file, which sort of defeats the purpose of bower.

@lowe
Copy link
Collaborator

lowe commented Jul 12, 2015

Hey @tomsommer, I added a separate zxcvbn-async-bower.js file for bower setup with instructions in the README, it should just work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants