-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zxcvbn-async.js contains hard coded incorrect path #67
Comments
+1 Please fix this |
I did this on purpose to make it as easy as possible to set up zxcvbn, as well as allow people to download the bulk from Dropbox's CDN. That said, I've seen enough confusion that I don't mind changing. |
Thanks. Could you recompile the coffee too? Or what is the procedure for the .js files? |
There is an issue with the change. If zxcvbn.js is stored in /bower_components/zxcvbn/zxcvbn.js the call from /bower_components/zxcvbn/zxcvbn-async.js with src = 'zxcvbn.js' will call '/zxcvbn.js', resulting in a 404 I'm not entirely sure how to fix this without requiring people to edit the -async.js file, which sort of defeats the purpose of bower. |
Hey @tomsommer, I added a separate |
src="//dl.dropbox.com/u/209/zxcvbn/zxcvbn.js"
should probably be:
src="zxcvbn.js"
The text was updated successfully, but these errors were encountered: