Fix metrics for InstrumentedEE10Handler
#3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zUniQueX
force-pushed
the
fix-ee10-metrics
branch
from
c24ba6f
to
c134f96
Compare
zUniQueX
force-pushed
the
fix-ee10-metrics
branch
2 times, most recently
from
e6965ea
to
cd976b7
Compare
…fix bugs where metrics weren't collected
zUniQueX
force-pushed
the
fix-ee10-metrics
branch
from
cd976b7
to
80c084f
Compare
yaooqinn
pushed a commit
to apache/spark
that referenced
this pull request
Jun 12, 2024
### What changes were proposed in this pull request? Upgrade dropwizard metrics to 4.2.26. ### Why are the changes needed? There are some bug fixes as belows: - Correction for the Jetty-12 QTP metrics by dkaukov in dropwizard/metrics#4181 - Fix metrics for InstrumentedEE10Handler by zUniQueX in dropwizard/metrics#3928 The full release notes: https://github.com/dropwizard/metrics/releases/tag/v4.2.26 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Passed GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46932 from wayneguow/codahale. Authored-by: Wei Guo <guow93@gmail.com> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #3917, the
InstrumentedEE10Handlerdoesn't properly collect metrics in some cases, e.g. when a Jersey method returns a completedCompletableFuture.This PR performs the response metrics update after the Jetty
Callbackfinishes, i.e. the response is committed. This simplifies the logic between synchronous and asynchronous requests.Fixes #3917