Graphite: implement connection & socket timeout #4313
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphite
class methods does not have any explicit timeout. So when Graphite instance is not available, experiencing network issues or is overloaded with too many requests, reporter may hang for some long time.In my case (Spark metrics sink sending reports to Graphite) the lack of timeouts prevents Spark session from being stopped if Graphite instance is overloaded. This can last 5-10 minutes, sometimes even more.
What's changed:
connectionTimeoutMs
argument toGraphite
constructor (default 500ms)socketTimeoutMs
argument toGraphite
constructor (default 5s)