Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test module #6

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Add test module #6

merged 1 commit into from
Oct 31, 2016

Conversation

burdges
Copy link
Contributor

@burdges burdges commented Oct 26, 2016

There is maybe no reason for this in a macro only crate, but minor benefits exist according to http://stackoverflow.com/a/40271926/667457

I tested that adding #[cfg(test)] before each #[test] worked too, if that seemed preferable, but probably not

There is maybe no reason for this in a macro only crate, but minor
benefits exist according to http://stackoverflow.com/a/40271926/667457

I tested that adding #[cfg(test)] before each #[test] works too.
@droundy droundy merged commit ed7d0ac into droundy:master Oct 31, 2016
@droundy
Copy link
Owner

droundy commented Oct 31, 2016

Looks like a reasonable cleanup.

@burdges
Copy link
Contributor Author

burdges commented Oct 31, 2016

Appears #[test] actually does imply #[cfg(test)], so my original reasons for suggesting this are vapor. I suppose moving the quickcheck dependency to just the test module improves matters though, which I'd completely missed before. :)

@droundy
Copy link
Owner

droundy commented Oct 31, 2016

Yes, I assumed that was the main reason. And to accommodate any helper
functions for new tests introduced in the future.

On Mon, Oct 31, 2016, 1:57 PM Jeff Burdges notifications@github.com wrote:

Appears #[test] actually does imply #[cfg(test)], so my original reasons
for suggesting this are vapor. I suppose moving the quickcheck dependency
to just the test module improves matters though, which I'd completely
missed before. :)


You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
#6 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIZKXiDSmKza3_W6lkXW8vkxds2-tYQks5q5lYtgaJpZM4KhstV
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants