Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/other args #2

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Conversation

kylewhite21
Copy link
Contributor

Small change to allow more args to connect/1. I specifically needed to supply a ssh key passphrase. I also moved host and port to new args.

I haven't changed any docs or the README. I can make those edits if you want to pull this in.

@drowzy
Copy link
Owner

drowzy commented Nov 9, 2023

Thanks for the PR! Unrelated question, have you checked if your use case can be covered by using https://www.erlang.org/doc/man/ssh#tcpip_tunnel_to_server-5 (available since OTP-23)? That might be a more stanzdardized way of doing it. When I wrote this lib, that functionality was not yet in OTP.

@drowzy drowzy merged commit a58d86d into drowzy:master Nov 9, 2023
@kylewhite21
Copy link
Contributor Author

Hmm that function does seem to be exactly what I need. I'll have to try it out shortly. Thanks for pointing it out!

@kylewhite21
Copy link
Contributor Author

Thanks for the hint, that function is exactly what I needed. It's simplified a lot of things. But thanks for having this code to get me off the ground!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants