Postgresql doesn't start with pg_hibernator enabled

[hamann]

Hi,

I'm trying to get pg_hibernator running on Debian Wheezy with pg 9.3 from apt.postgresql.org. After installing and restarting pg I get the following error

vagrant@vagrant-base-wheezy-amd64:~$ sudo /etc/init.d/postgresql restart
[....] Restarting PostgreSQL 9.3 database server: main[....] The PostgreSQL server failed to start. 
Please check the log output: 2014-05-17 13:59:46 
UTC FATAL: incompatible library "/usr/lib/postgresql/9.3/lib/pg_hibernator.so": missing magic block 2014-05-17 13:59:46
[FAILHINT: Extension libraries are required to use the PG_MODULE_MAGIC macro. ... failed!
 failed!

vagrant@vagrant-base-wheezy-amd64:~$ cat /etc/debian_version
7.5
vagrant@vagrant-base-wheezy-amd64:~$ dpkg -l|grep -i postgresql
ii  libpq-dev                        9.3.4-1.pgdg70+1          amd64        header files for libpq5 (PostgreSQL library)
ii  libpq5                           9.3.4-1.pgdg70+1          amd64        PostgreSQL C client library
ii  pgdg-keyring                     2013.2                    all          keyring for apt.postgresql.org
ii  postgresql-9.3                   9.3.4-1.pgdg70+1          amd64        object-relational SQL database, version 9.3 server
ii  postgresql-client-9.3            9.3.4-1.pgdg70+1          amd64        front-end programs for PostgreSQL 9.3
ii  postgresql-client-common         154.pgdg70+1              all          manager for multiple PostgreSQL client versions
ii  postgresql-common                154.pgdg70+1              all          PostgreSQL database-cluster manager
ii  postgresql-server-dev-9.3        9.3.4-1.pgdg70+1          amd64        development files for PostgreSQL 9.3 server-side programming

[hamann]

I think the issue is here, because pg version is 9.3.4
But if I change that to < 90400, I get other errors:

vagrant@vagrant-base-wheezy-amd64:/vagrant/recipes/pg_hibernator/tmp-build/pg_hibernator-HEAD$ make clean && make
rm -f pg_hibernator.so   libpg_hibernator.a  libpg_hibernator.pc
rm -f pg_hibernate.o pg_hibernate_9.3.o
gcc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -fPIC -pie -I/usr/include/mit-krb5 -DLINUX_OOM_SCORE_ADJ=0 -fno-omit-frame-pointer -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -fpic -I. -I./ -I/usr/include/postgresql/9.3/server -I/usr/include/postgresql/internal -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/tcl8.5  -c -o pg_hibernate.o pg_hibernate.c
gcc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -fPIC -pie -I/usr/include/mit-krb5 -DLINUX_OOM_SCORE_ADJ=0 -fno-omit-frame-pointer -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -fpic -I. -I./ -I/usr/include/postgresql/9.3/server -I/usr/include/postgresql/internal -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/tcl8.5  -c -o pg_hibernate_9.3.o pg_hibernate_9.3.c
pg_hibernate_9.3.c:53:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token
pg_hibernate_9.3.c:55:3: warning: data definition has no type or storage class [enabled by default]
pg_hibernate_9.3.c:55:3: warning: type defaults to ‘int’ in declaration of ‘SharedState’ [-Wimplicit-int]
pg_hibernate_9.3.c:59:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
pg_hibernate_9.3.c:190:1: warning: ‘shmem_startup’ was used with no prototype before its definition [-Wmissing-prototypes]
pg_hibernate_9.3.c: In function ‘shmem_startup’:
pg_hibernate_9.3.c:195:5: error: ‘shared_mem’ undeclared (first use in this function)
pg_hibernate_9.3.c:195:5: note: each undeclared identifier is reported only once for each function it appears in
pg_hibernate_9.3.c: In function ‘BlockReaderMain’:
pg_hibernate_9.3.c:435:17: error: ‘shared_mem’ undeclared (first use in this function)
make: *** [pg_hibernate_9.3.o] Error 1

[gurjeet]

The first error message is not expected, and I'll investigate that tonight.

The second error message after your change to code is expected.

BTW, looks like you're using Vagrant script to automate it. It'd be faster for me to reproduce it if you could share that as well.

I have just pushed a commit in which I fixed an unrelated bug, so probably you can try the latest master branch again.

Thanks for trying out pg_hibernator.

[hamann]

The vagrant image is based on lxc. Does that help you?

[gurjeet]

@hamann I fixed the bug. The code can now be compiled for Postgres versions 9.3.x as well.

Thanks for the report.