Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve global B finding in Lgm_Trace #42

Merged
merged 2 commits into from
May 20, 2024
Merged

Improve global B finding in Lgm_Trace #42

merged 2 commits into from
May 20, 2024

Conversation

drsteve
Copy link
Owner

@drsteve drsteve commented Feb 29, 2024 •
edited
Loading

Cherry picked d9d9fdbe from #39. Includes manual merge of prior changes in master that hadn't been kept in sync.

TODO:

  • Resolve test failures, update tests if necessary (Initial review suggests that changes are minor and in line with expectation. However, needs more review to confirm that the changes are okay to include and update CI expected values)

@mghenderson64 @drsteve
Added some error messages. Fixed some global B finding steps
673ef8b 
Include merge of prior SKM/GC changes with cherry-picked MGH updates
@drsteve
Update test results (ClosedField, McIlwain_L, Lstar) for expected change
95c5f8f 
Minor channges in tracing result in different output. Changes are minor
and expected. Regression tests updated.
@drsteve drsteve marked this pull request as ready for review May 20, 2024 16:49
@drsteve drsteve merged commit 16b3c80 into master May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drsteve @mghenderson64