Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(exceptions): remove hard dependency on sqlalchemy just for a single exception type #314

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Jan 31, 2024

Fixes #313.

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 31, 2024

cc @gianm, only because you were the person who merged my last PR!

@gianm
Copy link
Member

gianm commented Feb 12, 2024

Looks reasonable to me.

@gianm gianm merged commit e47cf60 into druid-io:master Feb 12, 2024
@cpcloud cpcloud deleted the remove-sqlalchemy-hard-dependency branch February 17, 2024 11:46
@cpcloud
Copy link
Contributor Author

cpcloud commented Feb 17, 2024

@gianm No rush on this, but any idea when the next release might be published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inadvertent hard dependency on sqlalchemy
2 participants