Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for regex filter #52

Merged
merged 1 commit into from
May 20, 2016
Merged

Conversation

mistercrunch
Copy link
Member

I need support for this type of filter in order to add the feature in Caravel

@xvrl xvrl merged commit 6cb86c8 into druid-io:master May 20, 2016
@mistercrunch mistercrunch deleted the regex branch May 20, 2016 23:10
@mistercrunch
Copy link
Member Author

Oh that was quick. What's your release schedule to Pypi like? Just trying to figure out whether I should run off of my fork or wait a little.

@xvrl
Copy link
Member

xvrl commented May 21, 2016

I can release on Monday if you want.

On Friday, May 20, 2016, Maxime Beauchemin notifications@github.com wrote:

Oh that was quick. What's your release schedule to Pypi like? Just trying
to figure out whether I should run off of my fork or wait a little.


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#52 (comment)

dakra pushed a commit to atomx/pydruid that referenced this pull request May 21, 2016
@dakra
Copy link
Contributor

dakra commented May 21, 2016

I would appreciate a release to pypi as well.

One thing to note is that pull request #39 removed the from pydruid.foo import * entries in pydruid.client ( https://github.com/druid-io/pydruid/pull/39/files#diff-2d63becb1827470fd6f4928a4cde5b2eL30 ).

from foo import * is not a good practice in python so removing those is good but it
introduces incompatibilities with the old version.

So we can either,
a) change the documentation (README still uses from pydruid.client import * and note it in the changelog.
b) import all things explicit to make it backwards-compatible again.
(this is more work but considered better practice than import *, see for example sqlalchemy: https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/__init__.py )

@mistercrunch
Copy link
Member Author

Yeah I hit one of those as well and adapted my code. I had to change some references from client.query_dict to client.query_builder.last_query.query_dict.

You may want to crank the version to 0.3.0 (pre 1.0 release are expected to have breaking changes on the second digit) and add info in the release notes.

@xvrl
Copy link
Member

xvrl commented May 24, 2016

dakra pushed a commit to atomx/pydruid that referenced this pull request May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants