Spark: Recommend using singleton Beam. #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
force-pushed
the
spark-singleton
branch
2 times, most recently
from
8af3a6f
to
fef638f
Compare
gianm
changed the title
gianm
force-pushed
the
spark-singleton
branch
3 times, most recently
from
faf50f6
to
2d5c7ac
Compare
gianm
changed the title
gianm
force-pushed
the
spark-singleton
branch
from
2d5c7ac
to
aed35af
Compare
|
👍 |
| @@ -88,27 +86,39 @@ class SparkDruidTest | |||
| timekeeper.now = now | |||
| } | |||
| ) | |||
|
|
|||
| ssc.stop(true, true) | |||
| ssc.awaitTermination() | |||
There was a problem hiding this comment.
is this timeout protected somehow?
drcrallen
added a commit
that referenced
this pull request
Feb 5, 2016
Spark: Recommend using singleton Beam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114