Add some additional hourly cycling to minutely cycleBuckets #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Druid (given their availability group) This patch allows for additional tasks by introducing an hour dimension to the id.
This was referenced May 6, 2016
Closed
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #53 using a slightly modified version of the patch in #169 (% 3 instead of % 2, and updated tests). Should also cover #72.
The real fix for this issue is setting
druidBeam.taskLocator = overlord, which will work starting in Druid 0.9.1. Until then, this helps work around issues with longer windowPeriods on sub-hour granularity tasks.This should be backwards compatible, because existing firehoseIds are retrieved from the serialized dicts.
generateFirehoseIdis only called for new tasks.