Remove ARGV use during runtime
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwl
changed the title
drwl
commented
Sep 14, 2023
| @@ -35,11 +35,11 @@ def self.parse(args, existing_options = {}) | |||
| }.freeze | |||
|
|
|||
| def initialize(args, existing_options) | |||
| @args = args | |||
| @args = args.clone | |||
There was a problem hiding this comment.
Before this change, @args was a reference to ARGV. This resulted in parse_command and parser.parse! to modify ARGV.
|
|
||
| options = config_file_options.merge(parsed_options) | ||
|
|
||
| @options = Options.from(options, {}) | ||
| @options = Options.from(options, {working_args: remaining_args}) |
There was a problem hiding this comment.
Could probably come up with a better name
|
|
||
| # Note: This is currently broken as we don't set `is_rake` anywhere. | ||
| # It's an artifact from the old Annotate gem and how it did control flow. | ||
| model_files = list_model_files_from_argument(options) if !options[:is_rake] |
There was a problem hiding this comment.
:is_rake is a legacy option from the old Annotate gem, it's not used in this gem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
ARGVfrom being used implicitly during runtime. Before this change, ARGV would be used and modified inParser#parsewhich made it hard to reason about howModelFilesGetter#list_model_files_from_argumentworks.ARGVis still used at the time of execution but gets cloned inParser#new.