Adding Dry::Container::Mixin#each_pair
#25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In discussions with other developers, it was felt that being able to iterate over not just the registered keys, but to see what was registered would be very helpful. This is a step toward doing that.
|
Adding issue concerning rbx-2 (#27) |
|
Thanks for the PR. We have discussed this in the past and decided against adding it as nobody had a specific need for it, could you explain your use-case please? |
AMHOL
reviewed
Oct 14, 2016
| # toward doing that. | ||
| def each_pair(&block) | ||
| config.resolver.each_pair(_container, &block) | ||
| self |
There was a problem hiding this comment.
Still not sure on the feature as a whole yet, but I think that returning self here is a bad idea, it doesn't seem like a good candidate for method chaining and encourages mutation in some form or another
|
Why |
|
@jeremyf going to close this issue due to inactivity, please respond if this is still an issue that you think needs addressing and we can re-open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discussions with other developers, it was felt that being able to
iterate over not just the registered keys, but to see what was
registered would be very helpful. This is a step toward doing that.