[BUG] Uninitialized constant error for IDENTITY/Undefined

[bestwebua]

Describe the bug

Uninitialized constant error for IDENTITY/Undefined due using short namespaces.

NameError:
  uninitialized constant Dry::Core::ClassAttributes::IDENTITY
        def defines(*args, type: ::Object, coerce: IDENTITY) # rubocop:disable Metrics/PerceivedComplexity

To Reproduce

This issue appear in my project after dry-system version has been bumped from 0.25.0 to 0.26.0 (dry-core has been bumped from 0.8.1 to 0.9.0).

Expected behavior

No errors here :)

My environment

• Affects my production application: YES
• Ruby version: ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-darwin20]
• Bundler version: 2.3.23
• dry-core version: 0.9.0

PR

PR with fix this issue: #72

[solnic]

Hey thanks for the report. Could you upgrade to dry-system 0.27.0 and see if this goes away?

[bestwebua]

Hey thanks for the report. Could you upgrade to dry-system 0.27.0 and see if this goes away?

@solnic Yup. After update I see another error:

NameError:
  uninitialized constant Dry::System::Plugins
        extend Dry::System::Plugins

[marian13]

Describe the bug

Uninitialized constant error for IDENTITY/Undefined due using short namespaces.

NameError:
  uninitialized constant Dry::Core::ClassAttributes::IDENTITY
        def defines(*args, type: ::Object, coerce: IDENTITY) # rubocop:disable Metrics/PerceivedComplexity

To Reproduce

This issue appear in my project after dry-system version has been bumped from 0.25.0 to 0.26.0 (dry-core has been bumped from 0.8.1 to 0.9.0).

Expected behavior

No errors here :)

My environment

• Affects my production application: YES
• Ruby version: ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-darwin20]
• Bundler version: 2.3.23
• dry-core version: 0.9.0

PR

PR with fix this issue: #72

I am experiencing this error as well, but with dry-validation 😅

[bestwebua]

@marian13 With full namespaces it works like a charm with next dry stack:

gem 'dry-system', '~> 0.26.0'
gem 'dry-transaction', '0.13.3'
gem 'dry-transformer', '~> 0.1.1'
gem 'dry-validation', '~> 1.9'

[solnic]

How can I reproduce this? I tried this and it worked:

➜  ~ gem i dry-system
Fetching dry-system-0.27.1.gem
Successfully installed dry-system-0.27.1
1 gem installed

➜  ~ irb
irb(main):001:0> require 'dry-system'
=> true

➜  ~ gem i dry-validation
Successfully installed dry-validation-1.9.0
1 gem installed

➜  ~ irb
irb(main):001:0> require 'dry-validation'
=> true

[solnic]

@flash-gordon I believe we need to have require "dry/core/constants" in all places that refer to constants, they are not auto-loadable after all. WDYT?

[bestwebua]

@solnic Here is the place where app crushes:

require 'bundler'
require 'dotenv'
require_relative './environment'

Dotenv.load('.env', ".env.#{System::Environment.current_env}")

require 'dry/system/container' # place where raised an error
require 'zeitwerk'

module System
  class Container < Dry::System::Container
    use :env, inferrer: -> { System::Environment.current_env.to_sym }
    use :zeitwerk

    configure do |config|
      config.component_dirs.add('app') do |dir|
        dir.instance = proc do |component|
          component_type = ->(type) { component.identifier.include?(type) }
          component.loader.constant(component) if %w[jobs mailers serializers].any?(&component_type)
        end
      end

      config.component_dirs.add('lib') do |dir|
        dir.instance = proc do |component|
          component.loader.constant(component) if component.identifier.include?('services')
        end
      end
    end
  end

  Import = System::Container.injector
end

After bumping dry-system to 0.27.0 raised another error:

Failure/Error: require_relative '../system/container'

NameError:
  uninitialized constant Dry::System::Plugins

        extend Dry::System::Plugins
                          ^^^^^^^^^
# ./system/container.rb:9:in `<top (required)>'
# ./spec/spec_helper.rb:7:in `require_relative'
# ./spec/spec_helper.rb:7:in `<top (required)>'
# ------------------
# --- Caused by: ---
# LoadError:
#   cannot load such file -- dry/system/container
#   ./system/container.rb:9:in `<top (required)>'

As I understend my propose with fix is wrong, right?

[solnic]

You need to do require "dry/system" and it should work. This file sets up zeitwerk and the rest will autoload.

[bestwebua]

Yup. It's works, thanks:

require 'dry/system/container' -> require 'dry/system'

And sorry for mess.

[solnic]

@bestwebua I'm glad that it works and no worries. This was a helpful report. I should add more info to the dry-system release notes.