Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation #113

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Fix documentation #113

merged 3 commits into from
Jul 7, 2024

Conversation

k-dubil
Copy link
Contributor

@k-dubil k-dubil commented Jul 6, 2024

Fix some bugs I found in the documentation – Predicates, Operations and Builder sections.

Copy link
Member

@flash-gordon flash-gordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -31,7 +31,7 @@ end

is_number.call(1).success? # => true
is_number.call(2.0).success? # => true
is_number.call('3').success? # => false
is_number.call('3').success? # => true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, it wasn't obvious number? has coercion inside

@flash-gordon flash-gordon merged commit 3f1f1de into dry-rb:main Jul 7, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants