Update for dry-configurable settings separation #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we’ve introduced `Config#configured?` as public API to dry-configurable, we no longer need our own implementation, which decouples ourselves from dry-configurable internals.
This change has no material impact (the result is the same as calling finalize directly on config), but it ensures we continue to invoke the correct behavior if dry-configurable ever moves any logic to its class-level finalize method.
|
Since this is a fairly rote PR, I intend to merge it in a day or so (i.e. next time I'm working on this) to get ready for releasing both dry-configurable and dry-system. |
flash-gordon
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is that we stop relying on
Dry::Configurable::Configinternal implementation details by using the new#configured?API introduced in dry-rb/dry-configurable#143.While we're here, we make one other small tweak to improve dry-configurable compatibility: use dry-configurable's class-level
#finalizeinstead ofConfig#finalizedirectly, which will mean that we'll continue to have correct behaviour if dry-configurable ever moves any additional logic to this class-level method.