Use target_container alias to pass to providers #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible for users of dry-system to provide a subclass of the ProviderRegistrar where they can customise the target_container that their providers receive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ProviderRegistrar, create a newtarget_container(an alias of itscontainerattribute), and use thistarget_containerwhen creating providers.This makes it possible for users of dry-system to provide a subclass of the
ProviderRegistrarwhere they can customise the target_container that their providers receive.We need this so that providers in Hanami can receive their respective slice as the
target, making it possible for code inside the provider to interact naturally with the Hanami slice itself, as opposed to its internal container (which itself knows nothing about the broader Hanami app).As part of this change, make
ProviderRegistrarandProviderRegistrar#target_containerboth public API (with everything else about the provider registrar still remaining private).See hanami/hanami#1382 for an example of usage from a dry-system consumer.