Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning for cases with empty hash-like args #137

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Fix deprecation warning for cases with empty hash-like args #137

merged 4 commits into from
Jun 7, 2021

Conversation

bestwebua
Copy link
Contributor

Little addition for #136 (Re-allow Hash-like parameters to be passed to steps). It will fix deprecation warning for cases with empty hash-like args.

Screenshot 2021-06-06 at 3 14 04 PM

@bestwebua bestwebua requested a review from solnic as a code owner June 6, 2021 12:39
Copy link
Member

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo 🙂

spec/integration/transaction_spec.rb Outdated Show resolved Hide resolved
My bad) Thx!

Co-authored-by: Piotr Solnica <piotr.solnica@gmail.com>
@solnic solnic merged commit c49a7d8 into dry-rb:master Jun 7, 2021
@solnic
Copy link
Member

solnic commented Jun 7, 2021

Thanks! I'll push a patch release with this.

@bestwebua
Copy link
Contributor Author

Thanks! I'll push a patch release with this.

Thanks, Piotr! 👍

@bestwebua bestwebua deleted the fix-deprecation-warning-for-empty-hash-like-args branch June 7, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants