Default i18n messages should not replace pre-existing keys

[timriley]

If you have an app with i18n configured, and some local i18n keys to replace dry-validation message defaults, then later requiring dry-validation will overwrite those keys.

For example, if I set up i18n like this, in the boot sequence of my app:

require "i18n"
I18n.load_path += Dir["#{MyApp::Container.root}/apps/*/locales/**/*.yml"]
I18n.backend.load_translations

And where I have a .yml file like this:

en:
  errors:
    filled?: "Fill this thing, yo"

And then later on require a file that requires dry-validation, the errors.filled? key gets replaced with the default:

[1] pry(main)> I18n.t("errors.filled?")
=> "%{name} must be filled"

If, instead, I do a little hoop-jumping and force dry-v's i18n integration to load before I suppose my own locale files, then things work as I'd want:

require "i18n"

# Load dry-validation's i18n support first, so we can override if we want
require "dry/validation/messages/i18n"

I18n.load_path += Dir["#{Alpinist::Container.root}/apps/*/locales/**/*.yml"]

I18n.backend.load_translations

[1] pry(main)> I18n.t("errors.filled?")
=> "Fill this thing, yo"

You can see these examples in action in https://github.com/icelab/alpinist/tree/sign-in-and-users-crud.

I think the preferred behaviour here would be for dry-v not to do anything that might result in pre-existing keys being overwritten.

[solnic]

I'm not sure how to solve this to be honest. Does it work as expected when you unshift load path rather than append?

[solnic]

Sorry Tim but there's no way around that.

[timriley]

@solnic Fair enough! Thanks for looking into it.