This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
Nest sub-apps under umbrella namespace #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, in a newly generated “blog” umbrella project, the “main” sub-app’s module namespace will now be `Blog::Main` instead of just `Main`. This brings a few of benefits: - The conceptual clarity of sub-apps being nested under a single root project namespace (having the sub-apps being “siblings” to the root project made their relationship unclear) - Constant loading is now more straightforward when a sub-app wants to use a class defined in the root module. When referring to `Entities::Foo` in code within a `Blog::Main` sub-app, the resolved constant can now fall back to `Blog::Entities::Foo` (in the root namespace) if `Blog::Main::Entities::Foo` (a more specialised version, in the sub-app’s namespace) is not available. - Reduce global namespace pollution: only one top-level constant is used.
Now that sub-apps are nested, this style of reference to the Import modules is probably the way we’ll go.
timriley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, in a newly generated “blog” umbrella project, the “main” sub-app’s module namespace will now be
Blog::Maininstead of justMain.This brings a few of benefits:
Entities::Fooin code within aBlog::Mainsub-app, the resolved constant can now fall back toBlog::Entities::Foo(in the root namespace) ifBlog::Main::Entities::Foo(a more specialised version, in the sub-app’s namespace) is not available.