Persistent config on Qubes OS using debops.persistent_paths
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypid
force-pushed
the
add/persistent_paths
branch
from
d675e1b
to
d5cb3ef
Compare
ypid
added a commit
to ypid/debops-playbooks
that referenced
this pull request
Mar 16, 2017
ypid
added a commit
to ypid/debops-playbooks
that referenced
this pull request
Mar 16, 2017
drybjed
reviewed
Mar 16, 2017
defaults/main.yml
Outdated
| ## '/etc/systemd/system/multi-user.target.wants/tinc.service': | ||
| ## Note that bind-dirs in Qubes OS currently does not restore symlinks (only their destination). | ||
| ## This works for ypid_ as he does not want auto start on Qubes OS AppVMs anyway. | ||
| ## If you need it on Qubes OS, feel free to discuss and patch bind-dirs. |
There was a problem hiding this comment.
Are these comments save to parse by Ansible? I would have thought that they should be the main file comments, not comments included in the YAML text block.
There was a problem hiding this comment.
Thanks! Does not really look save you are right. That comment evolved somehow and I did not clean it up before opening the PR. Fixed.
Also, they might have been included in the YAML block.
|
Potentially wait with merging until https://github.com/debops/ansible-persistent_paths/issues/5 is fixed. |
ypid
force-pushed
the
add/persistent_paths
branch
from
d8eab25
to
acd72b2
Compare
drybjed
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to avoid the merge conflicts with debops#38. I hope this works for you.
Depends on: https://github.com/debops/ansible-persistent_paths/pull/4