-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge into lmdb #28
Comments
Into the LMDB distribution proper, from symas? That is highly unlikely to ever happen, since it's a pure C project and I don't think they're very enthusiastic about C++. Also, there are multiple C++ wrappers, so who is to say which one becomes the bundled version? I would impudently suggest that my fork of this project (https://github.com/hoytech/lmdbxx) be considered too. :) |
Yours is definitely more updated. I'm a package maintainer for Haiku, so trying to figure out which to use for our re-distribution. |
In my obviously biased opinion, if you are OK with requiring a C++17 or higher compiler, you should use my fork since it has some important bugfixes. |
@hoytech ow. Yours definitely isn't API compatible with this one. Maybe you should have bumped the major version number vs minor :-) |
Increased major version to signify that API has changed from the original fork. drycpp#28
Good point, sorry about that. Some of the API changes are necessary. I believe removing the templated accessor methods was especially important, they frequently caused bugs. Anyway I tagged a 1.0.0 release too: |
Describe the bug
This is one single header wrapped in an entire package. Maybe it should just be merged into lmdb? They accept pull requests.
The text was updated successfully, but these errors were encountered: