Introduce "nondilutable" attributions #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to account for the DIA allocation as well as the Old Abe allocation, and any other allocations that are "external."
countvajhula
requested review from
jairtrejo and
apromessi
and removed request for
jairtrejo and
apromessi
apromessi
reviewed
Apr 21, 2023
oldabe/money_in.py
Outdated
| ): | ||
| """ | ||
| If there is an incoming investment, find out what proportion it | ||
| represents of the overall (posterior) valuation of the project. | ||
| """ | ||
| nondilutable_shares = [a.share for a in attributions.values() if not a.dilutable] | ||
| nondilutable_proportion = sum(nondilutable_shares) | ||
| dilutable_proportion = 1 - nondilutable_proportion |
There was a problem hiding this comment.
Instead of getting the nondilutable total and subtracting from 1, maybe we should just get the dilutable total.
oldabe/money_in.py
Outdated
| if incoming_investment > 0: | ||
| share = incoming_investment / posterior_valuation | ||
| share = incoming_investment / (posterior_valuation * dilutable_proportion) |
There was a problem hiding this comment.
I'm not sure if the business logic here makes sense anymore... brain cannot math right now... but maybe we should think about this some more.
oldabe/money_in.py
Outdated
| for email in attributions: | ||
| nondilutable_shares = [a.share for a in attributions.values() if not a.dilutable] | ||
| nondilutable_proportion = sum(nondilutable_shares) | ||
| target_proportion = (Decimal("1") - nondilutable_proportion - incoming_attribution.share) / (Decimal('1') - nondilutable_proportion) |
There was a problem hiding this comment.
Maybe we should get the dilutable proportion here too instead of doing Decimal("1") - nondilutable_proportion
Pull Request Test Coverage Report for Build 4770245841Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This is to account for the DIA allocation as well as the Old Abe allocation, and any other allocations that are "external."
Public Domain Dedication
(Why: The freely released, copyright-free work in this repository represents an investment in a better way of doing things called attribution-based economics. Attribution-based economics is based on the simple idea that we gain more by giving more, not by holding on to things that, truly, we could only create because we, in our turn, received from others. As it turns out, an economic system based on attribution -- where those who give more are more empowered -- is significantly more efficient than capitalism while also being stable and fair (unlike capitalism, on both counts), giving it transformative power to elevate the human condition and address the problems that face us today along with a host of others that have been intractable since the beginning. You can help make this a reality by releasing your work in the same way -- freely into the public domain in the simple hope of providing value. Learn more about attribution-based economics at drym.org, tell your friends, do your part.)