Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MILP bipartite observations in the SOLVING stage ? #203

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

gasse
Copy link
Member

@gasse gasse commented Jun 23, 2021

@dchetelat do you think this will cause any issue ? I suppose if that passes all the tests then we should be ok ?

@gasse gasse requested a review from dchetelat June 23, 2021 19:59
@dchetelat
Copy link
Contributor

Hmm I told you it was fine on Slack, but thinking about it again I can think of a possible issue - cuts? Are cuts considered constraints?

@gasse
Copy link
Member Author

gasse commented Jun 23, 2021

Hmmm looks like the tests do fail...

        def test_extract(observation_function, model):
    
            """Obtain observation."""
    
            observation_function.before_reset(model)
    
            pytest.helpers.advance_to_stage(model, ecole.scip.Stage.Solving)
    
    >       observation_function.extract(model, False)
    
    E       ecole.core.scip.Exception: Constraint 0 cannot be expressed as a single linear constraint (type "bounddisjunction"), MilpBipartite observation cannot be extracted.
    ```

@dchetelat
Copy link
Contributor

I see - I wonder where it's coming from. Preprocessing? Branching? Cuts?

@gasse gasse changed the base branch from master to dev July 1, 2021 15:22
Base automatically changed from dev to master July 5, 2021 17:38
@gasse gasse changed the base branch from master to dev July 6, 2021 04:20
@gasse gasse changed the title Allow MILP bipartite observations in the SOLVING stage Allow MILP bipartite observations in the SOLVING stage ? Jul 7, 2021
@AntoinePrv AntoinePrv changed the base branch from dev to latest October 1, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants