Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust stringify settings to produce indented json #18

Merged
merged 2 commits into from
May 4, 2019
Merged

Adjust stringify settings to produce indented json #18

merged 2 commits into from
May 4, 2019

Conversation

slai11
Copy link
Contributor

@slai11 slai11 commented Apr 17, 2019 •
edited
Loading

Scope

  • beautify printed JSON for better user experience

TODO

  • add a small prettify for user to auto-format json code while still editing (will throw error if not valid json)

@slai11 slai11 marked this pull request as ready for review April 22, 2019 15:28
guangie88
guangie88 approved these changes Apr 25, 2019
View reviewed changes
Copy link
Collaborator

@guangie88 guangie88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works for me on docker-compose up --build with some JSON dummy subpolicy

@slai11 slai11 mentioned this pull request May 4, 2019
Closed
@slai11 slai11 merged commit f1f57ba into master May 4, 2019
@slai11 slai11 deleted the format-json branch May 4, 2019 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guangie88 guangie88 guangie88 approved these changes

@brandonyeoxg brandonyeoxg Awaiting requested review from brandonyeoxg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slai11 @guangie88