You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently, in PlanetPopulation modules, planet paramters a, e, p, and Rp are generated by calling gen_plan_params, while planet mass is generated by calling gen_mass. This causes issues and requires silly workarounds for populations (i.e., DulzPlavchan) that require planet mass to be based on radius. More importantly, we should always allows for correlation between any or all of these parameters.
Describe the solution you'd like
Planet mass should be added as an output to gen_plan_params, and gen_mass should be eliminated as a separate class method.
Additional context
These are the modules defining/calling gen_mass:
Prototypes/PlanetPopulation.py
Prototypes/SimulatedUniverse.py
Completeness/SubtypeCompleteness.py
Completeness/BrownCompleteness.py
PlanetPopulation/KeplerLike1.py
PlanetPopulation/KnownRVPlanets.py
PlanetPopulation/KeplerLike2.py
Here are the modules defining/calling gen_plan_params:
Is your feature request related to a problem? Please describe.
Currently, in PlanetPopulation modules, planet paramters a, e, p, and Rp are generated by calling
gen_plan_params
, while planet mass is generated by callinggen_mass
. This causes issues and requires silly workarounds for populations (i.e., DulzPlavchan) that require planet mass to be based on radius. More importantly, we should always allows for correlation between any or all of these parameters.Describe the solution you'd like
Planet mass should be added as an output to
gen_plan_params
, andgen_mass
should be eliminated as a separate class method.Additional context
These are the modules defining/calling gen_mass:
Here are the modules defining/calling gen_plan_params:
The text was updated successfully, but these errors were encountered: