Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate_dV in SotoStarShade : Conflicts in input , docstring and usage in minimize SlewTimes #353

Open
doctordoom54 opened this issue May 22, 2023 · 0 comments
Assignees
Labels

Comments

@doctordoom54
Copy link

  • calculate_dV method is called with less number of inputs in minimize_slewTimes. (for ex angular sep is not given as input)
  • The order of inputs also appears to be flipped in respect to the definition of the method
  • The inputs in calculate_dV don't match with the docstring
  • Internally in minimize_slewTimes the slewTime is given as output without proper units (d) which causes error in calculate_dV
  • calculate_dV fails to take in a single pair of targets (2 stars) and corresponding single slewTime.

Most of these errors can be checked visually, using SotoStarshade observatory module in a simulation should provide the same error.

Expected behavior
Minimizing slewTime based on constraint equations.

EXOSIMS version:

  • Current master branch ( v 3.13) contains the module with this error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants