Fix in operator wrong behavior #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivecoder
changed the title
n' # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
Is there a test case where either of those code blocks cause problems? |
Based on my previous comment, it seems like there was and I forgot to add to the commit. However, this PR is many years old and I no longer have the tests or remember the case. |
|
That sounds alarmingly true! All I can say at the moment is that all the
tests pass for py3. I have code for recursive bunches, default bunches, and
proxy bunches, so I'm fairly sure a dozen years ago--an entire interpreter
ago--the code was necessary. Now? I plan to write up the test cases with
the next branch, so we'll see. (After publishing 1.2.0 to pypi, ofc.)
…On Mon, Sep 23, 2024 at 4:58 AM Robert Oliveira ***@***.***> wrote:
Is there a test case where either of those code blocks cause problems?
Based on my previous comment, it seems like there was and I forgot to add
to the commit. However, this PR is many years old and I no longer have the
tests or remember the case.
—
Reply to this email directly, view it on GitHub
<#41 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALT24C5O46LB3C2KM2YKTZX7J33AVCNFSM6AAAAABORNKV4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXGYYDMOJRGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contains method is actually redundant and causes a strange behavior documented in the additional tests in this pull request.