Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security advisory suggested this has to be done #63

Merged
merged 1 commit into from
Jun 9, 2019

Conversation

nicferrier
Copy link

I pulled this to send you a PR about error handling but got this so I'll send you this one first:

~/jswork/clarinet $ npm i
npm WARN deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm notice created a lockfile as package-lock.json. You should commit this file.
added 10 packages from 6 contributors and audited 11 packages in 6.285s
found 1 critical severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details
~/jswork/clarinet $ npm audit
=== npm audit security report ===                        
                                                                                
# Run  npm install --save-dev mocha@6.1.4  to resolve 1 vulnerability
SEMVER WARNING: Recommended action is a potentially breaking change
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Critical      │ Command Injection                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ growl                                                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ mocha [dev]                                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ mocha > growl                                                │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/146                       │
└───────────────┴──────────────────────────────────────────────────────────────┘


found 1 critical severity vulnerability in 11 scanned packages
  1 vulnerability requires semver-major dependency updates.
~/jswork/clarinet $ npm i --save-dev mocha@6.1.4
+ mocha@6.1.4
added 109 packages from 45 contributors, removed 2 packages, updated 6 packages and audited 226 packages in 18.638s
found 0 vulnerabilities

The tests run fine so it all seems ok. I didn't update pug. Perhaps you'd like me to do that?

@evan-king evan-king merged commit 13abf53 into dscape:master Jun 9, 2019
@evan-king
Copy link
Collaborator

Looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants