(#204) - Follow db updates

[jo]

nano.follow_updates([params], [callback])

uses follow to create a solid _db_updates feed. please consult follow
documentation for more information as this is a very complete api on it's own

var feed = nano.follow_updates({since: "now"});
feed.on('change', function (change) {
  console.log("change: ", change);
});
feed.follow();
process.nextTick(function () {
  nano.db.create('alice');
});

[dscape]

Sorry I'm confused, why is this more than just updating the following dependency? I don't see any deleted code.

Thanks for the code, looking forward to understanding this a bit better

[jo]

Sorry if my explenation was not clear - I have added nano.follow which is similar to nano.db.follow but uses Follow to keep up with _db_updates instead of _changes.

[dscape]

Ok. If that's the case please de-duplicate the code and make sure they use the same helper function, but with the different URL. I'm ok with the API change but duplicated code makes it complicated (as noted by my remarks)

Thanks 💯

[dscape]

Also 📖 docs !

[jo]

Oh f* I forgot the docs.
And sure I will dry the code, good point!

[jo]

Here again, squashed, with docs.
The code now makes - forgive me my previous foolishness - use of the follow_db function, without the useless duplication.

[dscape]

Looks good. Are you sure you want to name it follow? Maybe db_updates instead?

Other than that, good to merge

[jo]

We have nano.db.changes and nano.db.follow and so I think its most consistent to call it nano.updates and nano.follow.

[jo]

What about follow_db_updates and also renaming updates into db_updates for ultimate clarity?

[jo]

Lets call it follow_updates and leave updates ok?

[jo]

Did the name change in code, commit msg as well as in issue and PR descriptions.
I think its ready to merge now.

[jo]

... and fixed the tests for updates: They have been failed after the switch which checks for _db_updates support if there was support.

[dscape]

merged :) publish?

[jo]

Thanks and yes please publish ;-)

[dscape]

done :)