-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add correct support for Reasons
#10
Conversation
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==================================
+ Coverage 97% 99% +1%
==================================
Files 6 7 +1
Lines 123 130 +7
==================================
+ Hits 120 129 +9
+ Misses 3 1 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 9 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)
Reason
Reasons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)
Pull Request (PR) description
ConvertFrom-Reason
was added which takes anarray of
[Reason]
and coverts it to an array of[System.Collections.Hashtable]
.ConvertTo-Reason
was renamedResolve-Reason
.ResourceBase
Reasons
in derived class-based resources is now expectedto use the type
[System.Collections.Hashtable[]]
(issue #4).This Pull Request (PR) fixes the following issues
Reasons
with type[Reason]
fails if two modules have type[Reason]
#4Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
DSC Community Testing Guidelines.
This change is