Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inclusion in Hyper-V cluster #210

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nyanhp
Copy link

@nyanhp nyanhp commented Apr 18, 2023

Pull Request (PR) description

Attempting to add cluster-awareness. Was unable to get a local build to run on (and found no info how to do it):

  • Fresh Linux VM
  • Fresh Windows Server 2022 (without Hyper-V module/feature)
  • Dev Workstation (With Hyper-V module/feature)

While the added code worked in my own lab and on site in the customer environment, I have no idea if tests will work, as some test cases for other resources randomly kept failing. So, apologies in advance. As a suggestion, a little 'How-to run a local build' would be appreciated.

Adding VMs to a cluster requires usage of PsDscRunAsCredential.

This Pull Request (PR) fixes the following issues

None

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@nyanhp
Copy link
Author

nyanhp commented Apr 18, 2023

All tests successfully passed, code coverage could not be reported

@nyanhp nyanhp marked this pull request as draft April 18, 2023 14:16
@nyanhp nyanhp marked this pull request as ready for review April 18, 2023 19:51
@nyanhp nyanhp force-pushed the clusterrole branch 3 times, most recently from 586fed6 to f04fab3 Compare April 20, 2023 09:37
This reverts commit 6112708.
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #210 (ac7b58a) into main (6c0e583) will increase coverage by 0%.
Report is 1 commits behind head on main.
The diff coverage is 90%.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #210   +/-   ##
===================================
  Coverage    83%    83%           
===================================
  Files        11     11           
  Lines      1441   1464   +23     
===================================
+ Hits       1203   1223   +20     
- Misses      238    241    +3     
Files Coverage Δ
...ce/DSCResources/DSC_VMDvdDrive/DSC_VMDvdDrive.psm1 98% <100%> (ø)
...rce/Modules/HyperVDsc.Common/HyperVDsc.Common.psm1 85% <100%> (-2%) ⬇️
source/DSCResources/DSC_VMHyperV/DSC_VMHyperV.psm1 85% <88%> (+<1%) ⬆️

@johlju johlju added the needs review The pull request needs a code review. label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants